[PATCH] mt76: mt7915: fix warning: variable 'temp' set but not used
Bo Jiao
bo.jiao at mediatek.com
Mon Feb 14 23:59:08 PST 2022
From: Bo Jiao <Bo.Jiao at mediatek.com>
fix warning: variable 'temp' set but not used,
please fold this into previous commit
Fixes: 91eeaef2523f ("mt76: mt7915: add support for MT7986")
Reported-by: kernel test robot <lkp at intel.com>
Signed-off-by: Bo Jiao <Bo.Jiao at mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt7915/init.c | 4 ++--
drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h | 3 ---
drivers/net/wireless/mediatek/mt76/mt7915/soc.c | 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
index 6a4fb4c..6b3749b 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
@@ -589,10 +589,10 @@ static void mt7915_wfsys_reset(struct mt7915_dev *dev)
msleep(100);
} else if (is_mt7986(&dev->mt76)) {
- mt7986_wmac_enable(dev);
+ mt7986_wmac_disable(dev);
msleep(20);
- mt7986_wmac_disable(dev);
+ mt7986_wmac_enable(dev);
msleep(20);
} else {
mt76_set(dev, MT_WF_SUBSYS_RST, 0x1);
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h b/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
index 3ffee35..6db0db1 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
@@ -322,9 +322,6 @@ struct mt7915_dev {
struct reset_control *rstc;
void __iomem *dcm;
void __iomem *sku;
-
- /* adie is inaccessible after wfsys poweron */
- u32 adie;
};
enum {
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/soc.c b/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
index fb72ab4..4394a51 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
@@ -125,7 +125,7 @@ mt7986_wmac_adie_efuse_read(struct mt7915_dev *dev, u8 adie,
return ret;
ret = read_poll_timeout(mt76_wmac_spi_read, temp,
- !FIELD_GET(MT_ADIE_EFUSE_KICK_MASK, val),
+ !temp && !FIELD_GET(MT_ADIE_EFUSE_KICK_MASK, val),
USEC_PER_MSEC, 50 * USEC_PER_MSEC, false,
dev, adie, MT_ADIE_EFUSE2_CTRL, &val);
if (ret)
--
2.18.0
More information about the Linux-mediatek
mailing list