[PATCH] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

[Russell King - ARM Linux]

On Wed, Jan 22, 2014 at 12:32:39PM +0800, Chris Ruehl wrote:
> diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
> index f7199c8..8645d6a 100644
> --- a/drivers/mmc/host/mxcmmc.c
> +++ b/drivers/mmc/host/mxcmmc.c
> @@ -347,7 +347,7 @@ static int mxcmci_setup_data(struct mxcmci_host *host, struct mmc_data *data)
>  		return 0;
>  
>  	for_each_sg(data->sg, sg, data->sg_len, i) {
> -		if (sg->offset & 3 || sg->length & 3 || sg->length < 512) {
> +		if (sg && (sg->offset & 3 || sg->length & 3 || sg->length < 512)) {

sg should never be NULL here - so this is probably papering over a bug.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".