[PATCH net-next v5 2/3] dt-bindings: net: allwinner: add H616 EMAC1

Krzysztof Kozlowski krzk at kernel.org
Sun Sep 27 11:06:39 PDT 2026


On Mon, Sep 21, 2026 at 06:45:25PM -0600, James Hilliard wrote:
> The H616 secondary EMAC uses a separate system-control clock register
> and supports only RMII at 10/100 Mbps. Add its distinct compatible
> without an older fallback, since using the primary EMAC clock register
> would not work.
> 
> Constrain the PHY interface mode to RMII, matching the hardware.
> 
> Reviewed-by: Alastair D'Silva <alastair at d-silva.org>
> Tested-by: Alastair D'Silva <alastair at d-silva.org>

Tested-by is not applicable here, please drop. Don't blindly apply cover
letter tags.

With this corrected (and assuming Alastair actually did review the
binding... otherwise just don't use blanket cover letter tags):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list