[PATCH net-next v16 00/12] net: pcs: Introduce support for fwnode PCS
Jakub Kicinski
kuba at kernel.org
Wed Sep 23 20:11:58 PDT 2026
On Wed, 23 Sep 2026 10:31:49 +0200 Christian Marangi (Ansuel) wrote:
> Il giorno mer 23 set 2026 alle ore 02:25 Jakub Kicinski
> > On Tue, 22 Sep 2026 12:12:56 +0200 Christian Marangi (Ansuel) wrote:
> > > The remark on the fwnode patch are invalid. The driver is expected
> > > to return those error as probe defer is not supported.
> > > (a notifier and late attach/detach is used to align to phylink logic)
> > >
> > > For the specific Airoha PCS driver it's really speculation from the AI
> > > but HW doesn't work as described by AI.
> > >
> > > The only real comment that is valid is about the alternative way
> > > to give supported interface with the .get_capabilites OP.
> > >
> > > This is currently not supported as there isn't any user and it will
> > > be implemented as soon as there will be one. It's really to limit
> > > the patch delta of this change and to progress further.
> > >
> > > Maybe FIXME might be suitable?
> >
> > FWIW no preference here, I defer to the human reviewer.
> > We can treat the AI review as a hint if human reviewer thinks the code
> > is fine as is.
>
> Soo should I send v17 to fix AI that failed review?
> I think I didn't got this detail.
Sounded like Maxime was planning to take v16 for a spin.
More information about the linux-arm-kernel
mailing list