[PATCH v8 04/25] iommu/arm-smmu-v3: Move IDR parsing to common functions

[Mostafa Saleh]

On Wed, Sep 23, 2026 at 08:55:01AM -0300, Jason Gunthorpe wrote:
> On Wed, Sep 23, 2026 at 10:13:31AM +0000, Mostafa Saleh wrote:
> > > If kvm doesn't want to dev_err log that's fine, we should able to
> > > #define that away too shouldn't we? And maybe it does want to log?
> > 
> > The hypervisor can not print to the kernel console, so dev_err()
> > will not compile, I'd rather keep that outside and let the caller
> > decide what is a probe failure and print it's own message that keeping
> > the code and stubbing dev_err().
> 
> I'd rather stub the dev_err than split it like this. Every driver
> should still do these checks, it doesn't entirely make sense to omit
> them from the pkvm flow.. No print, fine (and really, pkvm has no
> tracing, printing or anything?)

Tracing is supported, trace_printk() might be coming soon to upstream,
but console printing is not supported at the moment.

> 
> As a stube I'd do something like arm_smmu_err(smmu, "blah"); pkvm can
> do whatever with that.

That's ok by me, we can define those next to the struct typedefs for
each one.

Thanks,
Mostafa

> 
> Jason