[PATCH v8 10/14] Revert "crypto: qce - Mark QCE as BROKEN"

[Bartosz Golaszewski]

On Tue, 22 Sep 2026 07:42:28 +0200, Demi Marie Obenour
<demiobenour at gmail.com> said:
> On 9/21/26 08:58, Bartosz Golaszewski wrote:
>>
>>  config CRYPTO_DEV_QCE
>> -	tristate "Qualcomm crypto engine accelerator"
>> -	depends on (BROKEN && ARCH_QCOM) || COMPILE_TEST
>> +	tristate "Qualcomm crypto engine offloader"
>> +	depends on ARCH_QCOM || COMPILE_TEST
>>  	depends on HAS_IOMEM
>>  	help
>> -	  This driver supports Qualcomm crypto engine accelerator
>> -	  hardware. To compile this driver as a module, choose M here. The
>> -	  module will be called qcrypto.
>> +	  This driver supports Qualcomm crypto engine offloader hardware. To
>> +	  compile this driver as a module, choose M here. The module will be
>> +	  called qcrypto.
>>
>> -	  This driver does not have exclusive access to the
>> -	  hardware, causing races with the secure world.  It
>> -	  is also slower than the CPU.
>> +	  NOTE: This driver does not have exclusive access to the hardware,
>> +	  causing races with the secure world. It is also *slower* than the
>> +	  CPU for the same algorithms. Use at your own risk!
>
> Would it make sense to clarify that this is only an issue if you pass
> do_register_algos=1?  With do_register_algos=0 (the default), the
> driver is perfectly safe (unless you made a mistake elsewhere) and
> saves power, so most people want it on.
>
> Also, if I understand your previous messages correctly, Linux currently
> doesn't use any of the features that would cause the races with the
> secure world.
>

Yeah, I guess it makes sense. Sashiko still says the series fails to apply, so
I need to see with Herbert if he wants me to resend or if the change you're
requesting should be a follow-up.

Bart