[PATCH net 0/3] net: stmmac: fix failed MTU reopening and hardware resume
James Hilliard
james.hilliard1 at gmail.com
Mon Sep 21 09:54:01 PDT 2026
A failed stmmac MTU-change reopen leaves the netdev administratively up
after its replacement DMA resources have been freed. A later close can
repeat NAPI shutdown and IRQ or DMA-resource teardown. A failed hardware
resume similarly leaves an up interface with NAPI already disabled, so
closing it can hang in a second napi_disable().
Fix these error paths by tracking whether the data path is open and
closing the netdev through the network core after failed reinitialization.
For failed resume, release the suspended data path without disabling NAPI
again. Allow phylink to finish shutdown directly from its suspended state
without restarting a MAC whose hardware setup has failed.
Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
---
These fixes were previously posted as patches 1-3 of the H616 EMAC1 v4
series. Split them into a separate net series as requested by Maxime
Chevallier. The sun8i MAC-reset change, EMAC1 binding and variant remain
in the net-next series.
Changes since that posting:
- Adapt the failed-resume fix to the net tree's older stmmac_resume()
implementation, leaving timestamping behavior unchanged.
- Add a Fixes tag for the phylink suspend/stop handling.
Previous posting:
https://patch.msgid.link/20260920-submit-h616-emac1-v1-v4-0-8347dfe2eb7d@gmail.com
To: Russell King <linux at armlinux.org.uk>
To: Andrew Lunn <andrew at lunn.ch>
To: Heiner Kallweit <hkallweit1 at gmail.com>
To: "David S. Miller" <davem at davemloft.net>
To: Eric Dumazet <edumazet at google.com>
To: Jakub Kicinski <kuba at kernel.org>
To: Paolo Abeni <pabeni at redhat.com>
To: Joakim Zhang <qiangqing.zhang at nxp.com>
To: "Russell King (Oracle)" <rmk+kernel at armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier at bootlin.com>
To: Andrew Lunn <andrew+netdev at lunn.ch>
To: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
To: Alexandre Torgue <alexandre.torgue at foss.st.com>
To: Christian Marangi <ansuelsmth at gmail.com>
To: Tiezhu Yang <yangtiezhu at loongson.cn>
To: Huacai Chen <chenhuacai at kernel.org>
Cc: netdev at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: linux-stm32 at st-md-mailman.stormreply.com
Cc: linux-arm-kernel at lists.infradead.org
---
James Hilliard (3):
net: phylink: allow stopping a suspended instance
net: stmmac: close the interface after a failed MTU reopen
net: stmmac: close the interface after failed hardware resume
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 39 ++++++++++++++++++-----
drivers/net/phy/phylink.c | 16 ++++++++++
3 files changed, 49 insertions(+), 8 deletions(-)
---
base-commit: 1e24c4f2ee44be0eee94092b5d13cbdb4bdf0d60
change-id: 20260921-submit-stmmac-reset-fixes-v1-7c98b92d29a9
Best regards,
--
James Hilliard <james.hilliard1 at gmail.com>
More information about the linux-arm-kernel
mailing list