[PATCH v4 07/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller
Larisa Ileana Grigore
larisa.grigore at oss.nxp.com
Mon Sep 21 01:22:19 PDT 2026
On 9/18/2026 12:49 PM, Krzysztof Kozlowski wrote:
> On 17/09/2026 11:15, Larisa Grigore wrote:
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: nxp,s32n79-ufshc
>> + - const: jedec,ufs-2.0
>
> Continuing discussion from v1, why replacing one fallback with another?
> So previously it was compatible with 3.0, but now it is not and it
> became compatible with 2.0?
>
> I cannot find any software user of any of these fallbacks, thus IMO it
> should be dropped, unless UFS folks have some arguments for keeping it?
>
Thank you! I will drop the JEDEC fallback compatible. Looking at the
existing UFS bindings, not all controllers provide such a fallback (for
example, Renesas UFS controllers), and I could not identify any software
user for it either.
>> +
>> + reg:
>> + items:
>> + - description: UFS Host Controller registers
>> + - description: System Control Module registers
>> +
>> + reg-names:
>> + items:
>> + - const: ufshc
>> + - const: scm
>> +
>> + clocks:
>> + maxItems: 1
>> + description: UFS core clock
>
> Drop description, redundant.
>
I will drop it.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - clocks
>> +
> Best regards,
> Krzysztof
Regards,
Larisa
More information about the linux-arm-kernel
mailing list