[PATCH 1/2] arm64: dts: rockchip: drop unused i2s0 from rk3399-firefly

Yaozhong Li yaozhonguwl at gmail.com
Sun Sep 20 23:34:00 PDT 2026


Please drop this series.

The commit message claims that nothing on this board uses i2s0. That is
true for the DAI, but I missed that its pin groups also list GPIO4_A0:

  i2s0-8ch-bus           ... <4 RK_PA0 1 &pcfg_pull_none>
  i2s0-8ch-bus-bclk-off  ... <4 RK_PA0 1 &pcfg_pull_none>

That pin carries SCLK_I2S_8CH_OUT, the MCLK the RT5640 runs on:

  rt5640: rt5640 at 1c {
          clocks = <&cru SCLK_I2S_8CH_OUT>;
          clock-names = "mclk";
  };

Dropping the whole &i2s0 override therefore leaves the codec clock pin
without its mux configuration and analog audio stops working. I have
reproduced that on the board. Sorry for not catching it before sending.

The correct change must split the MCLK pin into its own group, attach
that group to i2s1, and disable the otherwise unused i2s0 controller in
the same patch.

Patch 2/2 depends on this one - with i2s0 still enabled there is no
pl330 channel left for i2s2 - so it cannot stand on its own either. It
is resent unchanged as part of the v2 series rather than separately.

Could you please mark both patches as superseded in patchwork.

Sorry for the noise.



More information about the linux-arm-kernel mailing list