[PATCH 2/8] dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588
Rob Herring (Arm)
robh at kernel.org
Fri Sep 18 09:41:18 PDT 2026
On Thu, 17 Sep 2026 15:49:14 +0200, Sebastian Reichel wrote:
> From: Nicolas Frattaroli <nicolas.frattaroli at collabora.com>
>
> RK3588's DFI has pclks for each channel. They just weren't noticed as
> missing until now because nothing ever gates them, and they're ungated
> by default on power-on.
>
> The RK3399 clock situation needs no changes, as there the hardware
> really just has one monitoring unit for both channels.
>
> Add these clocks to the binding, so that drivers for this device can
> properly know about their existence.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli at collabora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> ---
> .../bindings/devfreq/event/rockchip,dfi.yaml | 84 ++++++++++++++++++----
> 1 file changed, 72 insertions(+), 12 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml: properties:clock-names: {'minItems': 1, 'maxItems': 4, 'items': [{'enum': ['pclk_ddr_mon', 'pclk_ddr_mon_ch0']}, {'const': 'pclk_ddr_mon_ch1'}, {'const': 'pclk_ddr_mon_ch2'}, {'const': 'pclk_ddr_mon_ch3'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260917-rockchip-dfi-cleanup-v1-2-4f00a97a69a6@collabora.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
More information about the linux-arm-kernel
mailing list