[PATCH v2 net-next] dt-bindings: net: Use consistent indentation in the example
Alex Elder
elder at ieee.org
Tue Sep 15 08:59:44 PDT 2026
On 9/14/26 10:56 AM, Krzysztof Kozlowski wrote:
> Correct indentation in the examples to consistent 2- or 4-spaces
> indentation to fix dt-check-style warnings ("example 0
> [indent-consistent] indent mismatch ..."). Preferred is 4-spaces, but
> re-indenting entire example just for that is too much churn.
>
> In cortina,gemini-ethernet.yaml also drop the wrongly indented mdio bus,
> because it is not necessary for the example.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>
Overall looks good to me (but the IPA binding in particular is good).
Acked-by: Alex Elder <elder at riscstar.com>
>
> ---
>
> Changes in v2:
> 1. Mention mdio bus removal.
> ---
> .../bindings/net/brcm,asp-v2.0.yaml | 2 +-
> .../bindings/net/cortina,gemini-ethernet.yaml | 52 ++++++--------
> .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 4 +-
> .../bindings/net/intel,dwmac-plat.yaml | 6 +-
> .../devicetree/bindings/net/mdio-gpio.yaml | 16 ++---
> .../bindings/net/mscc,vsc7514-switch.yaml | 8 +--
> .../devicetree/bindings/net/qcom,ipa.yaml | 10 +--
> .../bindings/net/realtek,rtl82xx.yaml | 6 +-
> .../bindings/net/socionext,uniphier-ave4.yaml | 32 ++++-----
> .../bindings/net/ti,cpsw-switch.yaml | 70 +++++++++----------
> .../bindings/net/wireless/mediatek,mt76.yaml | 32 ++++-----
> .../bindings/net/wireless/qcom,ath10k.yaml | 2 +-
> 12 files changed, 114 insertions(+), 126 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> index a3db6d594c8c..7fcc564e820c 100644
> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> @@ -123,7 +123,7 @@ examples:
> phy0: ethernet-phy at 1 {
> reg = <1>;
> };
> - };
> + };
>
> mdio at ce14 {
> compatible = "brcm,asp-v2.1-mdio";
> diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> index f0b5bea2458d..da9bc170cd54 100644
> --- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> @@ -87,18 +87,6 @@ examples:
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/cortina,gemini-clock.h>
> #include <dt-bindings/reset/cortina,gemini-reset.h>
> - mdio0: mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - phy0: ethernet-phy at 1 {
> - reg = <1>;
> - device_type = "ethernet-phy";
> - };
> - phy1: ethernet-phy at 3 {
> - reg = <3>;
> - device_type = "ethernet-phy";
> - };
> - };
>
> ethernet at 60000000 {
> compatible = "cortina,gemini-ethernet";
> @@ -110,28 +98,28 @@ examples:
> ranges;
>
> gmac0: ethernet-port at 0 {
> - compatible = "cortina,gemini-ethernet-port";
> - reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
> - <0x6000a000 0x2000>; /* Port 0 GMAC */
> - interrupt-parent = <&intcon>;
> - interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> - resets = <&syscon GEMINI_RESET_GMAC0>;
> - clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
> - clock-names = "PCLK";
> - phy-mode = "rgmii";
> - phy-handle = <&phy0>;
> + compatible = "cortina,gemini-ethernet-port";
> + reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
> + <0x6000a000 0x2000>; /* Port 0 GMAC */
> + interrupt-parent = <&intcon>;
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon GEMINI_RESET_GMAC0>;
> + clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
> + clock-names = "PCLK";
> + phy-mode = "rgmii";
> + phy-handle = <&phy0>;
> };
>
> gmac1: ethernet-port at 1 {
> - compatible = "cortina,gemini-ethernet-port";
> - reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
> - <0x6000e000 0x2000>; /* Port 1 GMAC */
> - interrupt-parent = <&intcon>;
> - interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> - resets = <&syscon GEMINI_RESET_GMAC1>;
> - clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
> - clock-names = "PCLK";
> - phy-mode = "rgmii";
> - phy-handle = <&phy1>;
> + compatible = "cortina,gemini-ethernet-port";
> + reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
> + <0x6000e000 0x2000>; /* Port 1 GMAC */
> + interrupt-parent = <&intcon>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon GEMINI_RESET_GMAC1>;
> + clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
> + clock-names = "PCLK";
> + phy-mode = "rgmii";
> + phy-handle = <&phy1>;
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> index ea285ef3e64f..fab6aa6237e9 100644
> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> @@ -127,8 +127,8 @@ examples:
> phy-mode = "internal";
>
> fixed-link {
> - speed = <1000>;
> - full-duplex;
> + speed = <1000>;
> + full-duplex;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> index 62c1da36a2b5..d1522216d32b 100644
> --- a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> +++ b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> @@ -91,9 +91,9 @@ examples:
> snps,tx-queues-to-use = <2>;
> snps,tx-sched-wrr;
> queue0 {
> - snps,weight = <0x10>;
> - snps,dcb-algorithm;
> - snps,priority = <0x0>;
> + snps,weight = <0x10>;
> + snps,dcb-algorithm;
> + snps,priority = <0x0>;
> };
>
> queue1 {
> diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.yaml b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> index eb4171a1940e..36e51aaae9c0 100644
> --- a/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> @@ -45,13 +45,13 @@ examples:
> };
>
> mdio0: mdio {
> - compatible = "virtual,mdio-gpio";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - gpios = <&qe_pio_a 11>,
> - <&qe_pio_c 6>;
> - ethphy0: ethernet-phy at 0 {
> - reg = <0>;
> - };
> + compatible = "virtual,mdio-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpios = <&qe_pio_a 11>,
> + <&qe_pio_c 6>;
> + ethphy0: ethernet-phy at 0 {
> + reg = <0>;
> + };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> index 86a9c3fc76c8..d825130b54b4 100644
> --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> @@ -197,10 +197,10 @@ examples:
> <0x71040000 0x10000>,
> <0x71050000 0x10000>,
> <0x71060000 0x10000>;
> - reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
> - "port2", "port3", "port4", "port5", "port6",
> - "port7", "port8", "port9", "port10", "qsys",
> - "ana", "s0", "s1", "s2";
> + reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
> + "port2", "port3", "port4", "port5", "port6",
> + "port7", "port8", "port9", "port10", "qsys",
> + "ana", "s0", "s1", "s2";
>
> ethernet-ports {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 68ec76fe4473..38e3830512fe 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -246,14 +246,14 @@ examples:
> qcom,remote-pid = <5>;
>
> ipa_smp2p_out: ipa-ap-to-modem {
> - qcom,entry-name = "ipa";
> - #qcom,smem-state-cells = <1>;
> + qcom,entry-name = "ipa";
> + #qcom,smem-state-cells = <1>;
> };
>
> ipa_smp2p_in: ipa-modem-to-ap {
> - qcom,entry-name = "ipa";
> - interrupt-controller;
> - #interrupt-cells = <2>;
> + qcom,entry-name = "ipa";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> };
>
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> index 45033c31a2d5..07b39ef1fc62 100644
> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -91,8 +91,8 @@ examples:
> #size-cells = <0>;
>
> ethphy1: ethernet-phy at 1 {
> - reg = <1>;
> - realtek,clkout-disable;
> - realtek,aldps-enable;
> + reg = <1>;
> + realtek,clkout-disable;
> + realtek,aldps-enable;
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
> index 4eb63b303cff..8c8622160abb 100644
> --- a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
> +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
> @@ -121,22 +121,22 @@ examples:
> - |
> ether: ethernet at 65000000 {
> compatible = "socionext,uniphier-ld20-ave4";
> - reg = <0x65000000 0x8500>;
> - interrupts = <0 66 4>;
> - phy-mode = "rgmii";
> - phy-handle = <ðphy>;
> - clock-names = "ether";
> - clocks = <&sys_clk 6>;
> - reset-names = "ether";
> - resets = <&sys_rst 6>;
> - socionext,syscon-phy-mode = <&soc_glue 0>;
> + reg = <0x65000000 0x8500>;
> + interrupts = <0 66 4>;
> + phy-mode = "rgmii";
> + phy-handle = <ðphy>;
> + clock-names = "ether";
> + clocks = <&sys_clk 6>;
> + reset-names = "ether";
> + resets = <&sys_rst 6>;
> + socionext,syscon-phy-mode = <&soc_glue 0>;
>
> - mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - ethphy: ethernet-phy at 1 {
> - reg = <1>;
> - };
> - };
> + ethphy: ethernet-phy at 1 {
> + reg = <1>;
> + };
> };
> + };
> diff --git a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> index 8b5da602a2e8..4d24dadfaa5d 100644
> --- a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> @@ -192,50 +192,50 @@ examples:
> interrupt-names = "rx_thresh", "rx", "tx", "misc";
>
> ethernet-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - cpsw_port1: port at 1 {
> - reg = <1>;
> - label = "port1";
> - mac-address = [ 00 00 00 00 00 00 ];
> - phys = <&phy_gmii_sel 1>;
> - phy-handle = <ðphy0_sw>;
> - phy-mode = "rgmii";
> - ti,dual-emac-pvid = <1>;
> - };
> + cpsw_port1: port at 1 {
> + reg = <1>;
> + label = "port1";
> + mac-address = [ 00 00 00 00 00 00 ];
> + phys = <&phy_gmii_sel 1>;
> + phy-handle = <ðphy0_sw>;
> + phy-mode = "rgmii";
> + ti,dual-emac-pvid = <1>;
> + };
>
> - cpsw_port2: port at 2 {
> - reg = <2>;
> - label = "wan";
> - mac-address = [ 00 00 00 00 00 00 ];
> - phys = <&phy_gmii_sel 2>;
> - phy-handle = <ðphy1_sw>;
> - phy-mode = "rgmii";
> - ti,dual-emac-pvid = <2>;
> - };
> + cpsw_port2: port at 2 {
> + reg = <2>;
> + label = "wan";
> + mac-address = [ 00 00 00 00 00 00 ];
> + phys = <&phy_gmii_sel 2>;
> + phy-handle = <ðphy1_sw>;
> + phy-mode = "rgmii";
> + ti,dual-emac-pvid = <2>;
> + };
> };
>
> davinci_mdio_sw: mdio at 1000 {
> - compatible = "ti,cpsw-mdio","ti,davinci_mdio";
> - reg = <0x1000 0x100>;
> - clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
> - clock-names = "fck";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - bus_freq = <1000000>;
> + compatible = "ti,cpsw-mdio","ti,davinci_mdio";
> + reg = <0x1000 0x100>;
> + clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
> + clock-names = "fck";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + bus_freq = <1000000>;
>
> - ethphy0_sw: ethernet-phy at 0 {
> - reg = <0>;
> - };
> + ethphy0_sw: ethernet-phy at 0 {
> + reg = <0>;
> + };
>
> - ethphy1_sw: ethernet-phy at 1 {
> - reg = <1>;
> - };
> + ethphy1_sw: ethernet-phy at 1 {
> + reg = <1>;
> + };
> };
>
> cpts {
> - clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 25>;
> - clock-names = "cpts";
> + clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 25>;
> + clock-names = "cpts";
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index ae6b97cdc44b..bf4116b057d2 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -325,22 +325,22 @@ examples:
> r0 {
> regdomain = "FCC";
> txpower-5g {
> - b0 {
> - channels = <36 48>;
> - rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
> - rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
> - /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
> - rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
> - /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
> - };
> - b1 {
> - channels = <100 181>;
> - rates-ofdm = /bits/ 8 <14 14 14 14 14 14 14 14>;
> - rates-mcs = /bits/ 8 <4 14 14 14 14 14 14 14 14 14 14>;
> - txs-delta = <12 9 6>;
> - rates-ru = /bits/ 8 <7 14 14 14 14 14 14 14 14 14 14 14 14>;
> - };
> - };
> + b0 {
> + channels = <36 48>;
> + rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
> + rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
> + /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
> + rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
> + /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
> + };
> + b1 {
> + channels = <100 181>;
> + rates-ofdm = /bits/ 8 <14 14 14 14 14 14 14 14>;
> + rates-mcs = /bits/ 8 <4 14 14 14 14 14 14 14 14 14 14>;
> + txs-delta = <12 9 6>;
> + rates-ru = /bits/ 8 <7 14 14 14 14 14 14 14 14 14 14 14 14>;
> + };
> + };
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> index e667d78b3ab3..a52cb8a0d409 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> @@ -408,4 +408,4 @@ examples:
> "msi15",
> "legacy";
> ieee80211-freq-limit = <5470000 5875000>;
> - };
> + };
More information about the linux-arm-kernel
mailing list