[PATCH 4/4] usb: ohci-st: disable controller wakeup on removal
Patrice CHOTARD
patrice.chotard at foss.st.com
Tue Sep 15 02:34:58 PDT 2026
On 9/15/26 03:20, Myeonghun Pak wrote:
> Probe enables controller wakeup after the OHCI core marks controllers with
> RemoteWakeupConnected as wakeup-capable. Removal does not undo this, so the
> wakeup source can remain attached after driver unbind.
>
> Disable controller wakeup after removing the HCD.
>
> This issue was identified during our ongoing static-analysis research
> while reviewing kernel code.
>
> Fixes: d115837259ad ("usb: host: ohci-st: Add OHCI driver support for ST STB devices")
> Cc: stable at vger.kernel.org
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000 at gmail.com>
> Signed-off-by: Ijae Kim <ae878000 at gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512 at gmail.com>
> ---
> drivers/usb/host/ohci-st.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c
> --- a/drivers/usb/host/ohci-st.c
> +++ b/drivers/usb/host/ohci-st.c
> @@ -235,6 +235,7 @@
> int clk;
>
> usb_remove_hcd(hcd);
> + device_wakeup_disable(hcd->self.controller);
>
> if (pdata->power_off)
> pdata->power_off(dev);
Hi Myeonghun
Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>
Thanks
Patrice
More information about the linux-arm-kernel
mailing list