[PATCH v4 2/2] arm64: dts: freescale: add MR-NAVQ95 basic board support

[Ahmad Fatoum]

Hello,

On 9/10/26 5:08 PM, Laurentiu Mihalcea wrote:
> 
> Hi Ahmad,
> 
> On 9/9/2026 9:20 AM, Ahmad Fatoum wrote:
>> On 9/9/26 5:39 PM, Laurentiu Mihalcea wrote:
>>> From: Laurentiu Mihalcea <laurentiu.mihalcea at nxp.com>
>>> +	memory at 80000000 {
>>> +		device_type = "memory";
>>> +		/* actual size filled in by the bootloader */
>>> +		reg = <0x0 0x80000000 0 0x80000000>;
>>
>> If the board has at least 2G always, this is fine.
> 
> the board only ships with 16GB LPDDR5 so yes, it'll always have at least 2GB.
> While the current size is fine, maybe it would be better to change it to 16GB?
> Will have to update the commit message as well since "up to 16GB of LPDDR5 memory"
> might be a bit misleading.
> 
> my other option was to leave the size set to 0x0 like some QCOM DTSIs seem to do.
> Not sure what the preferred way of handling this is?

IMO, the DT should not claim a memory size that's less than what's
available across variants. So either 2G, 16G or just dropping it is fine
by me. No need to change this on my account.

>>> +&usdhc2 {
>>> +	bootph-pre-ram;
>>> +	bus-width = <4>;
>>> +	cd-gpios = <&gpio3 0 GPIO_ACTIVE_LOW>;
>>> +	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
>>> +	pinctrl-1 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
>>> +	pinctrl-2 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
>>> +	pinctrl-3 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
>>> +	pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";
>>
>> Looks unexpected to have same pinctrl groups for the higher speeds.
>> Are higher speed modes even possible on this board?
>>
>> If not, I would suggest dropping the extra states.
> 
> The pin configuration is chosen to meet the timing requirements of the 200MHz
> state. Because of this, I would expect the configuration to be appropriate for
> lower frequencies as well.
> 
> The intention is to use the same configuration as MX95-19x19-EVK since, from what
> I've been told, the trace lengths are similar to those of the EVK.

Ok. If you can actually attain higher rates this way, then nothing needs
to be changed.

> Thanks for taking the time to review this! :)

Cheers,
Ahmad

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |