[PATCH v4 3/6] iio: adc: bcm_iproc_adc: use devm-managed clock
mdshahid03 at gmail.com
mdshahid03 at gmail.com
Tue Sep 8 10:23:56 PDT 2026
From: Mohammad Shahid <mdshahid03 at gmail.com>
Convert the ADC clock to use devm-managed APIs to simplify
resource cleanup.
Signed-off-by: Mohammad Shahid <mdshahid03 at gmail.com>
---
drivers/iio/adc/bcm_iproc_adc.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 21bd51da9cd6..d6f82f8ddee1 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -110,7 +110,6 @@ do { \
struct iproc_adc_priv {
struct regmap *regmap;
- struct clk *adc_clk;
struct mutex mutex;
int irqno;
int chan_val;
@@ -511,6 +510,7 @@ static int iproc_adc_probe(struct platform_device *pdev)
struct iproc_adc_priv *adc_priv;
struct iio_dev *indio_dev = NULL;
struct device *dev = &pdev->dev;
+ struct clk *adc_clk;
int ret;
indio_dev = devm_iio_device_alloc(dev, sizeof(*adc_priv));
@@ -530,10 +530,9 @@ static int iproc_adc_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(adc_priv->regmap),
"failed to get handle for tsc syscon\n");
- adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk");
- if (IS_ERR(adc_priv->adc_clk))
- return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk),
- "failed getting clock tsc_clk\n");
+ adc_clk = devm_clk_get_enabled(dev, "tsc_clk");
+ if (IS_ERR(adc_clk))
+ return dev_err_probe(dev, PTR_ERR(adc_clk), "failed to enable clock\n");
adc_priv->irqno = platform_get_irq(pdev, 0);
if (adc_priv->irqno < 0)
@@ -551,13 +550,9 @@ static int iproc_adc_probe(struct platform_device *pdev)
if (ret)
return ret;
- ret = clk_prepare_enable(adc_priv->adc_clk);
- if (ret)
- return dev_err_probe(dev, ret, "failed to enable clock\n");
-
ret = iproc_adc_enable(indio_dev);
if (ret)
- goto err_adc_enable;
+ return ret;
indio_dev->name = "iproc-static-adc";
indio_dev->info = &iproc_adc_iio_info;
@@ -575,8 +570,6 @@ static int iproc_adc_probe(struct platform_device *pdev)
err_clk:
iproc_adc_disable(indio_dev);
-err_adc_enable:
- clk_disable_unprepare(adc_priv->adc_clk);
return ret;
}
@@ -584,11 +577,9 @@ static int iproc_adc_probe(struct platform_device *pdev)
static void iproc_adc_remove(struct platform_device *pdev)
{
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
- struct iproc_adc_priv *adc_priv = iio_priv(indio_dev);
iio_device_unregister(indio_dev);
iproc_adc_disable(indio_dev);
- clk_disable_unprepare(adc_priv->adc_clk);
}
static const struct of_device_id iproc_adc_of_match[] = {
--
2.43.0
More information about the linux-arm-kernel
mailing list