[PATCH 0/2] Couple of SCMI race fixes
Cristian Marussi
cristian.marussi at arm.com
Tue Sep 8 08:39:51 PDT 2026
On Fri, Aug 14, 2026 at 08:15:32PM +0000, Roland Dreier via B4 Relay wrote:
> Noticed a couple of races in SCMI code around delayed responses that
> time out. These are probably nearly impossible to hit in practice but
> the fixes are pretty straightforward and it seems worth having the
> code be sound.
Hi,
apologies for the delay in this reviews...
Nice hardening work, Sashiko complains about a few unrelated things (of
course :P), there is only probably a good point around the update of
DEBUG_COUNTERS that you added
https://sashiko.dev/#/patchset/20260814-scmi-async-done-race-v1-0-335b163d77ee%40rivian.com
"Will this new counter actually increment for timed-out responses, or will it
be blocked by earlier validation logic?"
I mean please consider if you can improve the patch only regarding the
DEBUG_COUNTER update (probably moving the update where async_done is now
set to NULL is enough...)
Beside this, look good to me and in my testing everything was fine.
Thanks
Cristian
More information about the linux-arm-kernel
mailing list