[PATCH v5] stm: class: Add MIPI OST protocol support
Alexander Shishkin
alexander.shishkin at linux.intel.com
Fri Jan 30 01:48:05 PST 2026
Yingchao Deng <yingchao.deng at oss.qualcomm.com> writes:
> + for (i = 1; i < ARRAY_SIZE(str_ost_entity_type); i++) {
> + if (i == pn->entity_type)
> + sz += sysfs_emit_at(page, sz, "[%s] ", str_ost_entity_type[i]);
> + else
> + sz += sysfs_emit_at(page, sz, "%s ", str_ost_entity_type[i]);
> + }
Greg hates this. Documentation [0] says "preferably": "Attributes should
be ASCII text files, preferably with only one value per file.", but
somebody will get yelled at if this gets spotted, and since it's
probably going to be me, let's maybe not do this.
Also, the ST Microsystems people don't need to be CC'd on Software Trace
Module patches: it's the same TLA meaning 2 different things. Everybody
does this, so I'm assuming they're cool with it, but FYI.
[0] https://docs.kernel.org/filesystems/sysfs.html#attributes
Thanks,
--
Alex
More information about the linux-arm-kernel
mailing list