[PATCH v3 3/3] pinctrl: aspeed: add G7(AST2700) SoC0 pinctrl support

[Billy Tsai]

Hi Krzysztof,

> > +
> > +static const struct aspeed_pinmux_ops aspeed_g7_soc0_ops = {
> > +     .set = aspeed_g7_soc0_sig_expr_set,
> > +};
> > +
> > +static struct aspeed_pinctrl_data aspeed_g7_soc0_pinctrl_data = {

> Look at your existing drivers - what is missing here and in other places?

Based on existing drivers (like pinctrl-aspeed-g6.c), aspeed_pin_group,
aspeed_pin_function arrays and pinctrl_desc should be const. I will add
const to aspeed_g7_soc0_groups, aspeed_g7_soc0_functions and
aspeed_g7_soc0_pinctrl_desc.

However, aspeed_pinctrl_data itself is not const in existing drivers
(likely because it holds mutable data like regmaps). If you strictly meant
pinctrl_data should be const, please let me know, but I suspect you were
referring to the referenced arrays and consistency.

Best regards,

Billy Tsai