[PATCH 04/10] ASoC: rockchip: spdif: Use dev_err_probe
Sebastian Reichel
sebastian.reichel at collabora.com
Tue Jan 27 14:12:03 PST 2026
Hello Alexey,
On Tue, Jan 27, 2026 at 09:31:18PM +0400, Alexey Charkov wrote:
> > ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
> > - if (ret) {
> > - dev_err(&pdev->dev, "Could not register PCM\n");
> > - return ret;
> > - }
> > + if (ret)
> > + dev_err_probe(&pdev->dev, ret, "Could not register PCM\n");
>
> Shouldn't this one return the error code, instead of falling through
> to 'return 0'?
Yes, good catch. I will fix that up in v2.
Thanks,
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20260127/62bc676a/attachment-0001.sig>
More information about the linux-arm-kernel
mailing list