[PATCH v2] stm class: Fix Kconfig symbols
Randy Dunlap
rdunlap at infradead.org
Tue Jan 27 11:15:17 PST 2026
On 1/27/26 10:14 AM, Leo Yan wrote:
> Kconfig symbols must not include the CONFIG_ prefix. Remove the CONFIG_
> prefix for default values to work.
>
> The STM_PROTO_SYS_T config is selected by default when STM is enabled.
> However, its description currently says "If you don't know what this is,
> say N," which contradicts the default behavior. Update the description
> to say "Y" to align with the default setting.
>
> Fixes: a02509f301c6 ("stm class: Factor out default framing protocol")
> Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support")
> Signed-off-by: Leo Yan <leo.yan at arm.com>
Greg has already merged a patch to fix the symbols:
https://patch.msgid.link/20251228190502.2480758-1-rdunlap@infradead.org
> ---
> Changes in v2:
> - Updated STM_PROTO_BASIC description to align with default selection
> (James).
> - Link to v1: https://lore.kernel.org/r/20251217-fix_stm_kconfig-v1-1-531fb3674549@arm.com
> ---
> drivers/hwtracing/stm/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
> index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..8ab079785189052945521e9b0a93a0d458de37e0 100644
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> @@ -13,7 +13,7 @@ if STM
>
> config STM_PROTO_BASIC
> tristate "Basic STM framing protocol driver"
> - default CONFIG_STM
> + default STM
> help
> This is a simple framing protocol for sending data over STM
> devices. This was the protocol that the STM framework used
> @@ -28,7 +28,7 @@ config STM_PROTO_BASIC
>
> config STM_PROTO_SYS_T
> tristate "MIPI SyS-T STM framing protocol driver"
> - default CONFIG_STM
> + default STM
> help
> This is an implementation of MIPI SyS-T protocol to be used
> over the STP transport. In addition to the data payload, it
> @@ -38,7 +38,7 @@ config STM_PROTO_SYS_T
> The receiving side must be able to decode this protocol in
> addition to the MIPI STP, in order to extract the data.
>
> - If you don't know what this is, say N.
> + If you don't know what this is, say Y.
>
> config STM_DUMMY
> tristate "Dummy STM driver"
>
> ---
> base-commit: fcb70a56f4d81450114034b2c61f48ce7444a0e2
> change-id: 20251216-fix_stm_kconfig-a72f40c7612c
>
> Best regards,
More information about the linux-arm-kernel
mailing list