[PATCH v3 3/4] drm/v3d: Allocate all resources before enabling the clock

[Melissa Wen]

On 24/01/2026 14:48, Maíra Canal wrote:
> Hi Melissa,
>
> On 23/01/26 12:53, Melissa Wen wrote:
>>
>>
>> On 16/01/2026 17:19, Maíra Canal wrote:
>>> Move all resource allocation operations before actually enabling the
>>> clock, as those operations don't require the GPU to be powered on.
>> What are the benefits of doing it?
>
> This is mostly a preparation for the next patch. In the next patch, I'll
> move all code related to powering on and preparing the GPU into the
> resume() hook. Since resource allocation must occur before resume(),
> this patch prepares the necessary groundwork for that.

Can you include this explanation to the commit message?

>
>>>
>>> While here, use devm_reset_control_get_optional_exclusive() instead of
>>> open-code it.
>> Overall LGTM. But I think this patch could be split into smaller units.
>> Maybe something like:
>> 1. remove open-coded part
>> 2. split gem resource allocation from initialization
>> 3. move all resource allocation
>
> I can certainly do that. My initial thinking was to keep these changes
> together, since they are closely related and all serve the same
> preparatory goal for the upcoming resume() refactoring. From my
> perspective, keeping them together helps preserve that context.

As a reviewer, splitting these changes into separate patches would make 
review simpler.
I think the open-coded improvement isn't super attached to the resource 
allocation, right?
And you can preserve context in the commit message.

Melissa

>
> Best regards,
> - Maíra
>
>>
>> Melissa
>>