[PATCH v2] PCI: imx6: Fix device node reference leak in imx_pcie_probe()

[Hongxing Zhu]

> -----Original Message-----
> From: Felix Gu <ustc.gu at gmail.com>
> Sent: 2026Äê1ÔÂ24ÈÕ 23:43
> To: Hongxing Zhu <hongxing.zhu at nxp.com>; Lucas Stach
> <l.stach at pengutronix.de>; Lorenzo Pieralisi <lpieralisi at kernel.org>;
> Krzysztof Wilczy¨½ski <kwilczynski at kernel.org>; Manivannan Sadhasivam
> <mani at kernel.org>; Rob Herring <robh at kernel.org>; Bjorn Helgaas
> <bhelgaas at google.com>; Shawn Guo <shawnguo at kernel.org>; Sascha
> Hauer <s.hauer at pengutronix.de>; Pengutronix Kernel Team
> <kernel at pengutronix.de>; Fabio Estevam <festevam at gmail.com>; Trent
> Piepho <tpiepho at impinj.com>
> Cc: linux-pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> imx at lists.linux.dev; linux-kernel at vger.kernel.org; Felix Gu
> <ustc.gu at gmail.com>
> Subject: [PATCH v2] PCI: imx6: Fix device node reference leak in
> imx_pcie_probe()
>
> In imx_pcie_probe, np is obtained by of_parse_phandle() and must be
> released when it's no longer needed. However, it doesn't release the
> reference, which cuases a reference leak.
> Fix this by using the __free(device_node) cleanup handler to release the
> reference when it goes out of scope.
>
> Fixes: 1df82ec46600 ("PCI: imx: Add workaround for e10728, IMX7d PCIe PLL
> failure")
> Signed-off-by: Felix Gu <ustc.gu at gmail.com>
Acked-by: Richard Zhu <hongxing.zhu at nxp.com>
Hi Mani:
Please help to merge it after refine the commit refer to Bjorn's comments.
Thanks.

Best Regards
Richard Zhu
> ---
> Changes in v2:
> - Use __free(device_node) clean handler to fix the leak.
> - Link to v1:
> https://lore.ke/
> rnel.org%2Fr%2F20260124-pci_imx6-v1-1-6f4379fc5160%40gmail.com&data=
> 05%7C02%7Chongxing.zhu%40nxp.com%7Cf489385f9bdc4c71508908de5b67
> 727e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6390486970205
> 66603%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIw
> LjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%
> 7C%7C%7C&sdata=mJZl3iAqX71BeptkhNGzeP3eElGRUDnBhYabt265vqs%3D&r
> eserved=0
> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 1d8677d7de04..f459d05ecd7d 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1643,7 +1643,6 @@ static int imx_pcie_probe(struct platform_device
> *pdev)
>       struct device *dev = &pdev->dev;
>       struct dw_pcie *pci;
>       struct imx_pcie *imx_pcie;
> -     struct device_node *np;
>       struct device_node *node = dev->of_node;
>       int i, ret, domain;
>       u16 val;
> @@ -1670,7 +1669,8 @@ static int imx_pcie_probe(struct platform_device
> *pdev)
>               pci->pp.ops = &imx_pcie_host_dw_pme_ops;
>
>       /* Find the PHY if one is defined, only imx7d uses it */
> -     np = of_parse_phandle(node, "fsl,imx7d-pcie-phy", 0);
> +     struct device_node *np __free(device_node) =
> +             of_parse_phandle(node, "fsl,imx7d-pcie-phy", 0);
>       if (np) {
>               struct resource res;
>
>
> ---
> base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d
> change-id: 20260124-pci_imx6-f97d70887dfc
>
> Best regards,
> --
> Felix Gu <ustc.gu at gmail.com>