[PATCH v3] spi: xilinx: use device property accessors.
Michal Simek
michal.simek at amd.com
Fri Jan 23 06:14:22 PST 2026
On 1/23/26 13:40, Mark Brown wrote:
> On Fri, Jan 23, 2026 at 08:11:47AM +0100, Michal Simek wrote:
>> On 1/22/26 17:18, Andrew Lunn wrote:
>>> On Thu, Jan 22, 2026 at 09:00:29AM +0000, Abdurrahman Hussain via B4 Relay wrote:
>
>>>> + ret = device_property_read_u32(&pdev->dev,
>>>> + "xlnx,num-transfer-bits",
>>>> + &bits_per_word);
>
>>> It could be my grep foo is broken, but there does not appear to be any
>>> users of xlnx,num-transfer-bits and xlnx,num-ss-bits. So it would be
>>> better to just remove them. There is no point Maintaining an API
>>> nobody uses. And it would be silly to spread that API to ACPI if
>>> nobody it going to use it.
>
> There are no upstream users of this driver at all so obviously no use of
> the properties.
We are not wiring this driver in any DT because it is soft IP but it doesn't
mean that it is not used.
But as you see Abdurrahman is able to use this driver is one configuration.
These properties are stable for years and well documented.
Thanks,
Michal
More information about the linux-arm-kernel
mailing list