[PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes

[Pritam Manohar Sutar]

Hi 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 22 January 2026 07:05 PM
> To: Pritam Manohar Sutar <pritam.sutar at samsung.com>; robh at kernel.org;
> krzk+dt at kernel.org; conor+dt at kernel.org; alim.akhtar at samsung.com
> Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> samsung-soc at vger.kernel.org; linux-kernel at vger.kernel.org;
> rosa.pila at samsung.com; dev.tailor at samsung.com;
> faraz.ata at samsung.com; muhammed.ali at samsung.com;
> selvarasu.g at samsung.com
> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
> nodes
> 
> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> > Enable USB PHY and DWC3 USB controllers' nodes.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar at samsung.com>
> > ---
> >  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
> +++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > index f90f7704597c..5896dd69334a 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > @@ -160,15 +160,20 @@ &xtcxo {
> >  &usbdrd31_ssphy {
> >  	dvdd-supply = <&dummy_regulator>;
> >  	vdd18-supply = <&dummy_regulator>;
> > +	status = "okay";
> 
> You just added the node in the previous patch, so why it cant be enavled
> there?
> 
> >  };
> >
> >  &usbdrd31_hsphy {
> >  	dvdd-supply = <&dummy_regulator>;
> >  	vdd18-supply = <&dummy_regulator>;
> >  	vdd33-supply = <&dummy_regulator>;
> > +	status = "okay";
> >  };
> >
> >  &usbdrd31_dwc3 {
> > +	dr_mode = "otg";
> > +	usb-role-switch;
> > +	role-switch-default-mode = "peripheral";
> 
> Why did you add incomplete node in previous commit?
> 
> 
> Best regards,
> Krzysztof