[PATCH v3] spi: xilinx: use device property accessors.
Andrew Lunn
andrew at lunn.ch
Thu Jan 22 08:18:33 PST 2026
On Thu, Jan 22, 2026 at 09:00:29AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> From: Abdurrahman Hussain <abdurrahman at nexthop.ai>
>
> Switch to device property accessors.
>
> Signed-off-by: Abdurrahman Hussain <abdurrahman at nexthop.ai>
> ---
> Switch to generic device property accessors.
>
> Changed from v3:
>
> Removed the patches to make irq optional from the series
>
> 2.52.0
>
> base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
> ---
> drivers/spi/spi-xilinx.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index c86dc56f38b4..c4b70e95b695 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -405,11 +405,11 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> bits_per_word = pdata->bits_per_word;
> force_irq = pdata->force_irq;
> } else {
> - of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> - &num_cs);
> - ret = of_property_read_u32(pdev->dev.of_node,
> - "xlnx,num-transfer-bits",
> - &bits_per_word);
> + device_property_read_u32(&pdev->dev, "xlnx,num-ss-bits",
> + &num_cs);
> + ret = device_property_read_u32(&pdev->dev,
> + "xlnx,num-transfer-bits",
> + &bits_per_word);
It could be my grep foo is broken, but there does not appear to be any
users of xlnx,num-transfer-bits and xlnx,num-ss-bits. So it would be
better to just remove them. There is no point Maintaining an API
nobody uses. And it would be silly to spread that API to ACPI if
nobody it going to use it.
Andrew
More information about the linux-arm-kernel
mailing list