[PATCH 3/4] ASoC: pxa2xx-ac97: Remove platform_data
Andy Shevchenko
andriy.shevchenko at intel.com
Thu Jan 22 07:01:57 PST 2026
On Thu, Jan 22, 2026 at 04:58:59PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 22, 2026 at 08:44:59PM +0800, Peng Fan (OSS) wrote:
...
> > + if (dev->dev.of_node) {
> > + reset_gpio = of_get_named_gpio(dev->dev.of_node, "reset-gpios", 0);
> > + if (reset_gpio == -ENOENT)
> > + reset_gpio = -1;
> > + else if (reset_gpio < 0)
> > + return reset_gpio;
>
> No, please convert to devm_gpiod_get*() or even better to use reset-gpio driver.
> TL;DR: no (reinstantiated) of_get_named_gpio() or alike must be in the kernel.
Ah, you do it in the followup, right?
If that is the case (I'm going to look into it after this one)
Acked-by: Andy Shevchenko <andriy.shevchenko at intel.com>
And thanks for cleaning it up, eventually!
> > } else {
> > if (cpu_is_pxa27x())
> > reset_gpio = 113;
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list