[PATCH 3/3] gpio: brcmstb: allow parent_irq to wake

Andy Shevchenko andy.shevchenko at gmail.com
Wed Jan 21 23:45:56 PST 2026


On Thu, Jan 22, 2026 at 9:44 AM Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
> On Thu, Jan 22, 2026 at 3:06 AM Florian Fainelli
> <florian.fainelli at broadcom.com> wrote:

...

> > -static void brcmstb_gpio_quiesce(struct device *dev, bool save)
> > +static void brcmstb_gpio_quiesce(struct brcmstb_gpio_priv *priv, bool save)
> >  {
> > -       struct brcmstb_gpio_priv *priv = dev_get_drvdata(dev);
> >         struct brcmstb_gpio_bank *bank;
> >         u32 imask;
> >
> > -       /* disable non-wake interrupt */
> > -       if (priv->parent_irq >= 0)
> > -               disable_irq(priv->parent_irq);
> > -
> >         list_for_each_entry(bank, &priv->bank_list, node) {
> >                 if (save)
> >                         brcmstb_gpio_bank_save(priv, bank);

> One more thing, how is "save" being used? I can't see it other than a dead code.

Ah, it was a preexisted parameter, I was under the impression that it
was just added without use. Sorry for the noise.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list