[PATCH v3 3/3] spi: xilinx: use device property accessors.
Michal Simek
michal.simek at amd.com
Wed Jan 21 07:10:53 PST 2026
On 1/19/26 08:06, Abdurrahman Hussain via B4 Relay wrote:
> From: Abdurrahman Hussain <abdurrahman at nexthop.ai>
>
> Make the driver work on non-OF platforms.
>
> Signed-off-by: Abdurrahman Hussain <abdurrahman at nexthop.ai>
> ---
> drivers/spi/spi-xilinx.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 4aa67fc61cb6..9fb1da2fcce4 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -405,11 +405,11 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> bits_per_word = pdata->bits_per_word;
> force_irq = pdata->force_irq;
> } else {
> - of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> - &num_cs);
> - ret = of_property_read_u32(pdev->dev.of_node,
> - "xlnx,num-transfer-bits",
> - &bits_per_word);
> + device_property_read_u32(&pdev->dev, "xlnx,num-ss-bits",
> + &num_cs);
> + ret = device_property_read_u32(&pdev->dev,
> + "xlnx,num-transfer-bits",
> + &bits_per_word);
> if (ret)
> bits_per_word = 8;
> }
>
Let's get back to this patch itself. I think you should send v4 version of this
patch with updating commit message and saying that you are using generic device
helper functions.
Thanks,
Michal
More information about the linux-arm-kernel
mailing list