[PATCH v8 10/10] pinctrl: s32cc: set num_custom_params to 0
Bartosz Golaszewski
brgl at kernel.org
Tue Jan 20 04:16:17 PST 2026
On Tue, 20 Jan 2026 12:59:22 +0100, Khristine Andreea Barbulescu
<khristineandreea.barbulescu at oss.nxp.com> said:
> From: Andrei Stefanescu <andrei.stefanescu at oss.nxp.com>
>
> The `num_custom_params` was not set to 0 and the pinctrl_desc structure
> was not initialized with 0. This would result in errors when parsing
> pinconf properties from the device tree.
>
Shoudn't this come as first in the series and with a Fixes tag?
Bartosz
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu at oss.nxp.com>
> ---
> drivers/pinctrl/nxp/pinctrl-s32cc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> index 3e0c48068f08..27ea0b44a7aa 100644
> --- a/drivers/pinctrl/nxp/pinctrl-s32cc.c
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
> @@ -1272,6 +1272,7 @@ int s32_pinctrl_probe(struct platform_device *pdev,
> s32_pinctrl_desc->pctlops = &s32_pctrl_ops;
> s32_pinctrl_desc->pmxops = &s32_pmx_ops;
> s32_pinctrl_desc->confops = &s32_pinconf_ops;
> + s32_pinctrl_desc->num_custom_params = 0;
> s32_pinctrl_desc->owner = THIS_MODULE;
>
> ipctl->regions = devm_kcalloc(&pdev->dev, soc_data->mem_regions,
> --
> 2.50.1
>
>
More information about the linux-arm-kernel
mailing list