[PATCH v3 3/3] spi: xilinx: use device property accessors.

Michal Simek michal.simek at amd.com
Mon Jan 19 10:52:35 PST 2026



On 1/19/26 19:38, Mark Brown wrote:
> On Mon, Jan 19, 2026 at 09:47:11AM -0800, Abdurrahman Hussain wrote:
>>> On Jan 19, 2026, at 9:32 AM, Mark Brown <broonie at kernel.org> wrote:
> 
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.
> 
>>> You are just bindly making the DT properties available as _DSD
>>> properties on ACPI systems, ACPI is a completely different firmware
>>> interface with it's own idioms.  Does this interface make any sense on
>>> ACPI?
> 
>>  From the above link:
> 
>> "The special DT namespace link device ID, PRP0001, provides a means to
>> use the existing DT-compatible device identification in ACPI…"
> 
> ...
> 
>> Is this not appropriate?
> 
> This was specifically targetted at some embedded x86 systems where there
> was a goal to reuse device tree bindings for things that just can't be
> expressed well in ACPI.  _DSD is generally considered tasteless for more
> server style systems, AIUI the general approach preferred by ACPI
> forward OSs is to use some combination of DMI quirking and registering
> with a per-device ID (like the per generation fake PCI IDs that Intel
> uses for all IPs on their SoCs).  Just blindly accepting _DSD can end up
> with something that's not used because it's not what the ecosystem
> wants.

Is it a better way to use auxiliary bus as was recommended by Greg in past on 
drivers/misc/keba/cp500.c review?
https://lore.kernel.org/linux-i2c/2024060203-impeding-curing-e6cd@gregkh/

Thanks,
Michal



More information about the linux-arm-kernel mailing list