[PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
Jakub Kicinski
kuba at kernel.org
Sat Feb 28 08:31:11 PST 2026
On Fri, 27 Feb 2026 16:55:56 -0800 Jakub Kicinski wrote:
> On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote:
> > The AI review for patch 7 says:
> >
> > This commit fixes a bug but lacks a Fixes: tag. The commit modifies
> > behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add
> > .set_mode() and .validate() methods") by making phy_power_on() call
> > qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by
> > making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on
> > before attempting calibration.
> >
> > Should this commit include:
> >
> > Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods")
> >
> > which is _wrong_, this isn't a bug fix.
>
> Yes, that's what I thought but then I saw the other thread..
Trying to apply this now but stmmac parts don't apply on Linus's tree,
and Vinod wants a tag :( What do we do?
Could you, perhaps, send us a PR with this on top of Linus's tree
(a resolution of the inevitable conflict with net-next would be helpful
too).
Or do we give up on the tag?
More information about the linux-arm-kernel
mailing list