[PATCH] pinctrl: single: drop useless assignment in pcs_irq_set()

Sergey Shtylyov s.shtylyov at auroraos.dev
Fri Feb 27 12:15:14 PST 2026


In pcs_irq_set(), the 2nd pcs->read() call is only done to flush a posted
write -- the actually read value is ignored.  Drop the useless assignment.

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov at auroraos.dev>
---
The patch is against the for-next branch of Linus W.'s linux-pinctrl.git repo.

 drivers/pinctrl/pinctrl-single.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 288c9c9bce9a..d50122c694b9 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1423,7 +1423,7 @@ static inline void pcs_irq_set(struct pcs_soc_data *pcs_soc,
 		pcs->write(mask, pcswi->reg);
 
 		/* flush posted write */
-		mask = pcs->read(pcswi->reg);
+		pcs->read(pcswi->reg);
 		raw_spin_unlock(&pcs->lock);
 	}
 
-- 
2.53.0



More information about the linux-arm-kernel mailing list