[PATCH v7 14/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property
Nicolas Frattaroli
nicolas.frattaroli at collabora.com
Wed Feb 25 04:51:47 PST 2026
On Tuesday, 24 February 2026 13:43:10 Central European Standard Time Peter Wang (王信友) wrote:
> On Mon, 2026-02-16 at 14:37 +0100, Nicolas Frattaroli wrote:
> > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-
> > mediatek.c
> > index 230e11533eac..424533538b90 100644
> > --- a/drivers/ufs/host/ufs-mediatek.c
> > +++ b/drivers/ufs/host/ufs-mediatek.c
> > @@ -655,9 +655,6 @@ static void ufs_mtk_init_host_caps(struct ufs_hba
> > *hba)
> > if (of_property_read_bool(np, "mediatek,ufs-rtff-mtcmos"))
> > host->caps |= UFS_MTK_CAP_RTFF_MTCMOS;
> >
> > - if (of_property_read_bool(np, "mediatek,ufs-broken-rtc"))
> > - host->caps |= UFS_MTK_CAP_MCQ_BROKEN_RTC;
> > -
> > dev_info(hba->dev, "caps: 0x%x", host->caps);
> > }
> >
> > @@ -1185,8 +1182,6 @@ static int ufs_mtk_init(struct ufs_hba *hba)
> > hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL;
> >
> > hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_INTR;
> > - if (host->caps & UFS_MTK_CAP_MCQ_BROKEN_RTC)
> > - hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_RTC;
> >
>
> Maybe check the hardware version (host->ip_ver)
> and set UFSHCD_QUIRK_MCQ_BROKEN_RTC instead of removing it?
I do not have access to a complete list of hardware IP versions
that need this quirk applied. No upstream DTs seem to use it.
If MediaTek wants the quirk back, you can submit a patch to apply
it based on the ip_ver once this series has landed, as you have all
the necessary information.
>
> Thanks
> Peter
>
More information about the linux-arm-kernel
mailing list