Re: 回复: [PATCH v9 1/3] dt-bindings: soc: cix: document the syscon on Sky1 SoC

Krzysztof Kozlowski krzk at kernel.org
Wed Feb 25 03:46:04 PST 2026


On 25/02/2026 12:15, Gary Yang wrote:
> Hi Krzysztof:
> 
> I'm sorry for my mistakes.
> 
>> EXTERNAL EMAIL
>>
>> On 25/02/2026 11:29, Krzysztof Kozlowski wrote:
>>> On Tue, Feb 24, 2026 at 05:21:09PM +0800, Gary Yang wrote:
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    syscon at 16000000 {
>>>> +      compatible = "cix,sky1-s5-system-control", "syscon";
>>>> +      reg = <0x16000000 0x1000>;
>>>> +      #reset-cells = <1>;
>>>> +    };
>>>> diff --git a/include/dt-bindings/reset/cix,sky1-rst-fch.h
>> b/include/dt-bindings/reset/cix,sky1-rst-fch.h
>>>
>>> I am not going to repeat my reviews.
>>
>> Quoting myself last time from second email:
>>
>> "It's the last time I am asking you of it"
>>
>>>
>>> NAK, I mark it as changes requested in Patchwork.
>>>
>>> Krzysztof
>>>
>>
> 
> Sorry for missing your advices. We just come back from the Chinese New Year Festival.
> It almost takes two weeks, so we forget your advices. Do you mean that cix,sky1-rst-fch.h 
> should be named cix,sky1-system-control.h and cix,sky1-rst.h should be named cix,sky1-s5-system-control.h? 
> Are there other advices forgot, except this one? Please give us one more chances. 
> 
> If miss any information, please let us know. Thanks

The same filename as used for binding.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list