[PATCH net-next 7/7] net: sparx5: move remaining init functions from start() to probe()
Daniel Machon
daniel.machon at microchip.com
Wed Feb 25 01:05:30 PST 2026
Move sparx5_pgid_init(), sparx5_vlan_init(), and sparx5_board_init()
from sparx5_start() to probe(). These functions do not require cleanup.
Signed-off-by: Daniel Machon <daniel.machon at microchip.com>
---
drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
index 581f87eb9781..fb3010446707 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
@@ -727,12 +727,6 @@ static int sparx5_start(struct sparx5 *sparx5)
ANA_CL_FILTER_CTRL_FORCE_FCS_UPDATE_ENA,
sparx5, ANA_CL_FILTER_CTRL(idx));
- /* Init PGID table arbitrator */
- sparx5_pgid_init(sparx5);
-
- /* Setup VLANs */
- sparx5_vlan_init(sparx5);
-
/* Add host mode BC address (points only to CPU) */
sparx5_mact_learn(sparx5, sparx5_get_pgid(sparx5, PGID_CPU), broadcast,
NULL_VID);
@@ -743,8 +737,6 @@ static int sparx5_start(struct sparx5 *sparx5)
mutex_init(&sparx5->mdb_lock);
INIT_LIST_HEAD(&sparx5->mdb_entries);
- sparx5_board_init(sparx5);
-
/* Start Frame DMA with fallback to register based INJ/XTR */
err = -ENXIO;
if (sparx5->fdma_irq >= 0) {
@@ -939,6 +931,10 @@ static int mchp_sparx5_probe(struct platform_device *pdev)
}
}
+ sparx5_pgid_init(sparx5);
+ sparx5_vlan_init(sparx5);
+ sparx5_board_init(sparx5);
+
err = sparx5_calendar_init(sparx5);
if (err) {
dev_err(sparx5->dev, "Failed to initialize calendar\n");
--
2.34.1
More information about the linux-arm-kernel
mailing list