[PATCH v2 1/3] media: dt-bindings: rockchip,vdec: Correct reg-names order for RK35{76,88}
Krzysztof Kozlowski
krzk at kernel.org
Tue Feb 24 06:34:36 PST 2026
On 24/02/2026 15:07, Cristian Ciocaltea wrote:
> On 2/24/26 3:54 PM, Krzysztof Kozlowski wrote:
>> On 24/02/2026 14:48, Nicolas Dufresne wrote:
>>> Le mardi 24 février 2026 à 14:18 +0100, Krzysztof Kozlowski a écrit :
>>>> On 24/02/2026 14:14, Nicolas Dufresne wrote:
>>>>>>>
>>>>>>> reg-names:
>>>>>>> - items:
>>>>>>> + oneOf:
>>>>>>> - const: function
>>>>>>> - - const: link
>>>>>>> - - const: cache
>>>>>>> + - items:
>>>>>>> + - const: link
>>>>>>> + - const: function
>>>>>>> + - const: cache
>>>>>>
>>>>>> No, ABI break without point.
>>>>>
>>>>> Its not released yet, otherwise both order would need to be allowed.
>>>>>
>>>> Also, not true.
>>>>
>>>> git describe --contains c6ffb7e1fb90
>>>> v6.17-rc1~90^2~3
>>>
>>> Ack, I thought this was part of 7.0, it would have been logical to be part of
>>> 7.0-rc1 I must say. Whatever happen, backward compat will unfortunatly be
>>> needed.
>>
>>
>> I was here checking the binding, so the ABI. DTS maybe was in v7.0-rc1
>> indeed. Anyway, the commit msg should describe the impact on users of
>> this ABI, at least known users.
>
> My bad, I only checked the DTS changes which landed in v7.0-rc1, and wrongly
> assumed the binding also landed about the same time. I think it's unlikely
> there are any (external) users of this binding, but obviously we cannot be 100%
> sure.
>
> Would it be acceptable to extend the binding so that it allows both the current
> and the new proposed order to coexist?
Depends also on the drivers and that's your "users analysis" should
cover. If there are no known released users of relatively new ABI, it is
fine to propose the change with such explanation and reason - poor
hardware description because convention expects the main device's
address to be used as first "reg" entry.
You can have also oneOf with older list "deprecated: true", if want to
keep any users unaffected.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list