[PATCH net-next] net: stmmac: fix timestamping configuration after suspend/resume
Simon Horman
horms at kernel.org
Tue Feb 24 01:28:02 PST 2026
On Mon, Feb 23, 2026 at 12:19:08PM +0000, Russell King (Oracle) wrote:
> When stmmac_init_timestamping() is called, it clears the receive and
> transmit path booleans that allow timestamps to be read. These are
> never re-initialised until after userspace requests timestamping
> features to be enabled.
>
> However, our copy of the timestamp configuration is not cleared, which
> means we return the old configuration to userspace when requested.
> This is inconsistent. Fix this by clearing the timestamp configuration.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
>
> I'm in two minds whether this should go via net or net-next - no one
> has noticed that getting the timestamp configuration after resume
> doesn't reflect the hardware state. Here's the commit that introduced
> the problem:
>
> Fixes: d6228b7cdd6e ("net: stmmac: implement the SIOCGHWTSTAMP ioctl")
My feeling is that the bar is not if someone noticed or not.
So I would lean towards a fix for net in this case.
Regardless, feel free to include:
Reviewed-by: Simon Horman <horms at kernel.org>
More information about the linux-arm-kernel
mailing list