[PATCH 3/9] power: supply: max77705: Free allocated workqueue and fix removal order
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Mon Feb 23 03:29:03 PST 2026
On Mon, Feb 23, 2026 at 11:19:13AM +0100, Krzysztof Kozlowski wrote:
> On 23/02/2026 09:57, Andy Shevchenko wrote:
> > On Mon, Feb 23, 2026 at 08:27:31AM +0100, Krzysztof Kozlowski wrote:
...
> >> ret = devm_request_threaded_irq(dev, regmap_irq_get_virq(irq_data, MAX77705_CHGIN_I),
> >> NULL, max77705_chgin_irq,
> >> IRQF_TRIGGER_NONE,
> >> "chgin-irq", chg);
> >> - if (ret) {
> >> - dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n");
> >> - goto destroy_wq;
> >> - }
> >> + if (ret)
> >> + return dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n");
> >
> > This should be just
> >
> > return ret;
> >
> >
> > devm_*_irq() prints the message. No need to repeat this in the caller(s).
> >
>
> I guess separate commit then.
WFM!
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list