[RFC PATCH v2 02/13] hwspinlock: add callback to fill private data of a hwspinlock

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, 16 Feb 2026 at 09:29, Wolfram Sang
<wsa+renesas at sang-engineering.com> wrote:
> >    Don't you break the existing users of this API with this change? I see
> > you're fixing them up in the followup patches but that's not how it should
> > be done -- the compilation shouldn't be broken...
>
> I am not breaking them. The helper is an additional feature and the old
> way still works until patch 8. Until then, all users are converted.
>
> I built tested it :)

Is that the statistically most-used response to that question? ;-)

drivers/hwspinlock/sun6i_hwspinlock.c: In function ‘sun6i_hwspinlock_probe’:
drivers/hwspinlock/sun6i_hwspinlock.c:182:16: error: too few arguments
to function ‘devm_hwspin_lock_register’
  182 |         return devm_hwspin_lock_register(&pdev->dev,
priv->bank, &sun6i_hwspinlock_ops,
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~
[...]

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds