[RFC PATCH v2 05/13] hwspinlock: sprd: use new callback to initialize hwspinlock priv
Wolfram Sang
wsa+renesas at sang-engineering.com
Sun Feb 15 14:54:45 PST 2026
Apply the new helper to avoid using internal structures from the core.
Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
---
drivers/hwspinlock/sprd_hwspinlock.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c
index 0d08efbdfb07..c19b680d5fdf 100644
--- a/drivers/hwspinlock/sprd_hwspinlock.c
+++ b/drivers/hwspinlock/sprd_hwspinlock.c
@@ -70,10 +70,18 @@ static void sprd_hwspinlock_relax(struct hwspinlock *lock)
ndelay(10);
}
+static void *sprd_hwspinlock_init_priv(int local_id, void *init_data)
+{
+ void __iomem *base = init_data;
+
+ return base + HWSPINLOCK_TOKEN(local_id);
+}
+
static const struct hwspinlock_ops sprd_hwspinlock_ops = {
.trylock = sprd_hwspinlock_trylock,
.unlock = sprd_hwspinlock_unlock,
.relax = sprd_hwspinlock_relax,
+ .init_priv = sprd_hwspinlock_init_priv,
};
static void sprd_hwspinlock_disable(void *data)
@@ -86,8 +94,7 @@ static void sprd_hwspinlock_disable(void *data)
static int sprd_hwspinlock_probe(struct platform_device *pdev)
{
struct sprd_hwspinlock_dev *sprd_hwlock;
- struct hwspinlock *lock;
- int i, ret;
+ int ret;
if (!pdev->dev.of_node)
return -ENODEV;
@@ -123,16 +130,11 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev)
/* set the hwspinlock to record user id to identify subsystems */
writel(HWSPINLOCK_USER_BITS, sprd_hwlock->base + HWSPINLOCK_RECCTRL);
- for (i = 0; i < SPRD_HWLOCKS_NUM; i++) {
- lock = &sprd_hwlock->bank.lock[i];
- lock->priv = sprd_hwlock->base + HWSPINLOCK_TOKEN(i);
- }
-
platform_set_drvdata(pdev, sprd_hwlock);
return devm_hwspin_lock_register(&pdev->dev, &sprd_hwlock->bank,
&sprd_hwspinlock_ops, 0,
- SPRD_HWLOCKS_NUM);
+ SPRD_HWLOCKS_NUM, sprd_hwlock->base);
}
static const struct of_device_id sprd_hwspinlock_of_match[] = {
--
2.51.0
More information about the linux-arm-kernel
mailing list