回复: [PATCH v8 1/3] dt-bindings: soc: cix: document the simple-mfd syscon on Sky1 SoC

[Gary Yang]

Hi Krzysztof:

Thanks for your comments

> EXTERNAL EMAIL
> 
> On 09/02/2026 10:33, Gary Yang wrote:
> > There are two system control on Cix sky1 Soc. One is located in S0
> > domain, and the other is located in S0 and S5 domain. The system
> > control contains resets, usb typeC and more. At this point, only the
> > reset controller child is described as usb typeC uses it by phandle.
> >
> > Signed-off-by: Gary Yang <gary.yang at cixtech.com>
> 
> Subject is not correct now. There is no simple-mfd. There should not be even
> syscon, because it is Linux term. Just use the name of this device.
> 

Yes, I agree. We will fix it next version.

> > ---
> >  .../soc/cix/cix,sky1-system-control.yaml      |  42 +++++
> >  include/dt-bindings/reset/cix,sky1-rst-fch.h  |  42 +++++
> >  include/dt-bindings/reset/cix,sky1-rst.h      | 164
> ++++++++++++++++++
> >  3 files changed, 248 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> >  create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
> >  create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.ya
> > ml
> > b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.ya
> > ml
> > new file mode 100644
> > index 000000000000..5507deb54ebd
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-contro
> > +++ l.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/soc/cix/cix,sky1-system-control.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Cix Sky1 SoC system control register region
> > +
> > +maintainers:
> > +  - Gary Yang <gary.yang at cixtech.com>
> > +
> > +description:
> > +  An wide assortment of registers of the system controller on Sky1
> > +SoC,
> > +  including resets, usb, wakeup sources and so on.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - cix,sky1-system-control
> > +          - cix,sky1-s5-system-control
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    syscon at 16000000 {
> > +      compatible = "cix,sky1-s5-system-control", "syscon";
> > +      reg = <0x16000000 0x1000>;
> > +      #reset-cells = <1>;
> > +    };
> > diff --git a/include/dt-bindings/reset/cix,sky1-rst-fch.h
> > b/include/dt-bindings/reset/cix,sky1-rst-fch.h
> 
> Filename must match compatible.
> 
> I am pretty sure I gave such feedback to Cix before....
> 

Yes, You're right. I remember it. But please allow us to explain it.
This header file contains many macros for reset signals. We intend to use syscon as a common module.
So it is not only reset controller, it can also be used by other modules in futher. If the file named by syscon, 
Maybe make confuse. All right?

If miss any information, please let us know. Thanks

Best Regards
Gary

> Best regards,
> Krzysztof