[PATCH v4 7/7] ARM: dts: rockchip: rk3506: Add pinctrl and rmio dtsi for rk3506

[Krzysztof Kozlowski]

On 29/12/2025 10:00, Ye Zhang wrote:
>>> +
>>> +		/omit-if-no-ref/
>>> +		rm_io28_sai0_sdi0: rm-io28-sai0-sdi0 {
>>> +			rockchip,pins =
>>> +				<1 RK_PC3 7 &pcfg_pull_none>;
>>> +			rockchip,rmio-pins =
>>> +				<0 28 54>;
>>> +		};
>> Why are you defining all pins? This is wrong, your driver has to do it,
>> not DTS. All these definitions when not used are just pointless.
> 
> This file is auto-generated to provide a complete set of RMIO configurations.   Our intention is to offer a generic library for all future board developers, so they can simply pick the needed nodes by phandle without manually looking up register values in the datasheet every time.   This improves usability and standardization.
> 
> We also used the /omit-if-no-ref/ tag, so this will strictly not increase the size of the compiled DTB binary at all.
> 
> Could you please reconsider if this  approach is acceptable given the usability benefits?

What usability benefits? This is review and maintenance nightmare.

> 
> If you still consider the ~25k lines of source code bloat unacceptable for upstream, we will have to drop this generic dtsi file and let users (and ourselves) manually define only the required nodes when adding board support."
> 

I see no point in having such code. Upstream is not your SDK.

Best regards,
Krzysztof