[PATCH v2 14/15] soc: ti: wkup_m3_ipc: Use mbox_ring_doorbell() instead of NULL message
Douglas Anderson
dianders at chromium.org
Sat Feb 7 20:01:36 PST 2026
As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce
mbox_ring_doorbell()"), we want to switch all users of NULL mailbox
messages to use mbox_ring_doorbell().
This client only ever sent NULL messages, so the transition is
straightforward. We can remove the call to mbox_client_txdone(). The
call didn't do anything for NULL messages and it's now officially
documented not to be called for doorbells.
Signed-off-by: Douglas Anderson <dianders at chromium.org>
---
(no changes since v1)
drivers/soc/ti/wkup_m3_ipc.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 5845fc652adc..9f74f2dfc217 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -328,9 +328,9 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc)
* the RX callback to avoid multiple interrupts being received
* by the CM3.
*/
- ret = mbox_send_message(m3_ipc->mbox, NULL);
+ ret = mbox_ring_doorbell(m3_ipc->mbox);
if (ret < 0) {
- dev_err(dev, "%s: mbox_send_message() failed: %d\n",
+ dev_err(dev, "%s: mbox_ring_doorbell() failed: %d\n",
__func__, ret);
return ret;
}
@@ -343,7 +343,6 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc)
return -EIO;
}
- mbox_client_txdone(m3_ipc->mbox, 0);
return 0;
}
@@ -358,14 +357,13 @@ static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_ipc)
return -EIO;
}
- ret = mbox_send_message(m3_ipc->mbox, NULL);
+ ret = mbox_ring_doorbell(m3_ipc->mbox);
if (ret < 0) {
- dev_err(dev, "%s: mbox_send_message() failed: %d\n",
+ dev_err(dev, "%s: mbox_ring_doorbell() failed: %d\n",
__func__, ret);
return ret;
}
- mbox_client_txdone(m3_ipc->mbox, 0);
return 0;
}
--
2.53.0.rc2.204.g2597b5adb4-goog
More information about the linux-arm-kernel
mailing list