回复: [PATCH v7 3/3] arm64: dts: cix: add support for cix sky1 resets

[Gary Yang]

Hi Krzysztof:

I'm glad your comments.

> EXTERNAL EMAIL
> 
> On 04/02/2026 03:06, Gary Yang wrote:
> > There are two reset conctrollers on Cix Sky1 Soc. One is located in S0
> > domain, and the other is located in S0 and S5 domain.
> >
> > Signed-off-by: Gary Yang <gary.yang at cixtech.com>
> > ---
> >  arch/arm64/boot/dts/cix/sky1.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi
> > b/arch/arm64/boot/dts/cix/sky1.dtsi
> > index 64b76905cbff..37dca97b6b67 100644
> > --- a/arch/arm64/boot/dts/cix/sky1.dtsi
> > +++ b/arch/arm64/boot/dts/cix/sky1.dtsi
> > @@ -348,6 +348,13 @@ i3c1: i3c at 4100000 {
> >                       status = "disabled";
> >               };
> >
> > +             syscon: syscon at 4160000 {
> > +                     compatible = "cix,sky1-system-control", "syscon",
> > +                                  "simple-mfd";
> > +                     reg = <0x0 0x4160000 0x0 0x100>;
> > +                     #reset-cells = <1>;
> > +             };
> > +
> >               iomuxc: pinctrl at 4170000 {
> >                       compatible = "cix,sky1-pinctrl";
> >                       reg = <0x0 0x04170000 0x0 0x1000>; @@ -568,6
> > +575,13 @@ ppi_partition1: interrupt-partition-1 {
> >                       };
> >               };
> >
> > +             s5_syscon: s5-syscon at 16000000 {
> 
> Node names should be generic. See also an explanation and list of examples
> (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-
> basics.html#generic-names-recommendation
> If you cannot find a name matching your device, please check in kernel sources
> for similar cases or you can grow the spec (via pull request to DT spec repo).
> 
> e.g. syscon
> 

Yes, you're right. This is my bad. I have realized my stupid mistakes.
I get a lot from your comments. Thanks for your advices.
We will fix it on next version.

Best Regards
Gary

> 
> Best regards,
> Krzysztof