[PATCH v9 4/7] i2c: xiic: cosmetic cleanup
Andi Shyti
andi.shyti at kernel.org
Tue Feb 3 17:11:29 PST 2026
> >> Re-use dev pointer instead of referencing &pdev->dev everywhere.
> >
> > ...
> >
> >> - dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n",
> >> + dev_dbg(dev, "mmio %08lx irq %d scl clock frequency %d\n",
> >> (unsigned long)res->start, irq, i2c->i2c_clk);
> >
> > No need to do this here as we change the format string afterwards anyway.
> >
> > But I leave it up to Andi, I won't prevent this to go in, if he agrees.
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >
>
> No worries, I can do this in the following patch, since there is going to be
> a v 10 anyways.
This would be merged next week anyway, so, please, send a v10 as
there are many little changes (if we were out of time I would
have manually changed things before merging, but that's not the
case, yet).
Andi
More information about the linux-arm-kernel
mailing list