Re: [PATCH v3 3/3] arm64:?==?utf-8?q? dts: rockchip: Add OneThing Edge Cube series

[Dragan Simic]

Hello Jun,

On Monday, February 02, 2026 16:04 CET, Jun Yan <jerrysteve1101 at gmail.com> wrote:
> The OneThing Edge Cube (OEC) series features the RK3566 SoC, 8GB
> eMMC storage, and supports one SATA interface, one Gigabit Ethernet
> port, and one USB 3.0 port.
> 
> Other than the difference in RAM capacity, the OEC and OEC-turbo are
> identical in all other specifications.
> 
>   Specification:
>     - Rockchip RK3566
>     - LPDDR4X 2GB (OEC) / 4GB (OEC-turbo)
>     - eMMC 8GB
>     - Gigabit Ethernet port x 1
>     - USB 3.0 port x 1
>     - USB-C 2.0 port x 1
>     - 12V DC Power supply
>     - SATA 3.0 connector x 1
> 
> These devices do not have a PMIC, and their hardware circuit design
> is highly similar to that of the rk3566-box-demo[1]. Hardware schematics
> are not available at this time, with the vendor firmware dts available
> for reference[2].
> 
> Ethernet, USB 3.0 and SATA 3.0 ports tested, all working well.
> 
> [1] https://elixir.bootlin.com/linux/v6.18.6/source/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> [2] https://archive.org/download/wxy-oec-RK3566-4G-dump/wxy-oec-RK3566-4G-dump.dts
> 
> Signed-off-by: Jun Yan <jerrysteve1101 at gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../rockchip/rk3566-onething-oec-series.dts   | 312 ++++++++++++++++++
>  2 files changed, 313 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-onething-oec-series.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 4d384f153c13..234fa53abe17 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -104,6 +104,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353v.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353vs.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg503.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-odroid-m1s.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-onething-oec-series.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-orangepi-3b-v1.1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-orangepi-3b-v2.1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-onething-oec-series.dts b/arch/arm64/boot/dts/rockchip/rk3566-onething-oec-series.dts
> new file mode 100644
> index 000000000000..2007b93e190e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-onething-oec-series.dts
> @@ -0,0 +1,312 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include "rk3566.dtsi"
> +
> +/ {
> +	model = "OneThing OEC/OEC-turbo";
> +	compatible = "onething,oec-turbo", "onething,oec", "rockchip,rk3566";

Thanks for the v3!  After thinking a bit more about it, it would be better
to name the board dtb "rk3566-onething-edge-cube.dtb" and omit the "series"
part, because the only difference between the board variants is the amount
of DRAM.  Also, "onething,oec-turbo" should be removed from the compatibles,
and the single compatible renamed to "onething,edge-cube", because I see no
need to have an additional compatible, which may be added later if really
needed for some unforeseen differentiating purpose.

Also, it might be better to use "OneThing Edge Cube/Edge Cube Turbo" as the
combined name, because "Edge Cube" is more self-descriptive than just "OEC",
which may also help with various search engines down the road.