[PATCH] KVM: selftests: Track width of arm64's timer counter as "int", not "uint64_t"
Oliver Upton
oliver.upton at linux.dev
Fri Sep 26 12:48:04 PDT 2025
On Fri, Sep 26, 2025 at 08:58:38AM -0700, Sean Christopherson wrote:
> Store the width of arm64's timer counter as an "int", not a "uint64_t".
> ilog2() returns an "int", and more importantly using what is an "unsigned
> long" under the hood makes clang unhappy due to a type mismatch when
> clamping the width to a sane value.
>
> arm64/arch_timer_edge_cases.c:1032:10: error: comparison of distinct pointer types
> ('typeof (width) *' (aka 'unsigned long *') and 'typeof (56) *' (aka 'int *'))
> [-Werror,-Wcompare-distinct-pointer-types]
> 1032 | width = clamp(width, 56, 64);
> | ^~~~~~~~~~~~~~~~~~~~
> tools/include/linux/kernel.h:47:45: note: expanded from macro 'clamp'
> 47 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi)
> | ^~~~~~~~~~~~
> tools/include/linux/kernel.h:33:17: note: expanded from macro 'max'
> 33 | (void) (&_max1 == &_max2); \
> | ~~~~~~ ^ ~~~~~~
> tools/include/linux/kernel.h:39:9: note: expanded from macro 'min'
> 39 | typeof(x) _min1 = (x); \
> | ^
>
> Fixes: fad4cf944839 ("KVM: arm64: selftests: Determine effective counter width in arch_timer_edge_cases")
> Cc: Sebastian Ott <sebott at redhat.com>
> Signed-off-by: Sean Christopherson <seanjc at google.com>
In the absence of a __careless_clamp() :)
Reviewed-by: Oliver Upton <oliver.upton at linux.dev>
Thanks,
Oliver
More information about the linux-arm-kernel
mailing list