[PATCH v4 2/3] PCI: imx6: Rename imx8mm_pcie_enable_ref_clk() as imx8mm_pcie_clkreq_override()

[Hongxing Zhu]

> -----Original Message-----
> From: Frank Li <frank.li at nxp.com>
> Sent: 2025年9月22日 22:51
> To: Hongxing Zhu <hongxing.zhu at nxp.com>
> Cc: jingoohan1 at gmail.com; l.stach at pengutronix.de; lpieralisi at kernel.org;
> kwilczynski at kernel.org; mani at kernel.org; robh at kernel.org;
> bhelgaas at google.com; shawnguo at kernel.org; s.hauer at pengutronix.de;
> kernel at pengutronix.de; festevam at gmail.com; linux-pci at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; imx at lists.linux.dev;
> linux-kernel at vger.kernel.org
> Subject: Re: [PATCH v4 2/3] PCI: imx6: Rename imx8mm_pcie_enable_ref_clk()
> as imx8mm_pcie_clkreq_override()
> 
> On Mon, Sep 22, 2025 at 04:24:32PM +0800, Richard Zhu wrote:
> > To align the function name when add the CLKREQ# override clear
> > function later. Rename imx8mm_pcie_enable_ref_clk() as
> > imx8mm_pcie_clkreq_override(). No function changes.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu at nxp.com>
> > ---
> >  drivers/pci/controller/dwc/pci-imx6.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> > b/drivers/pci/controller/dwc/pci-imx6.c
> > index 80e48746bbaf..41f971693697 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -685,7 +685,7 @@ static int imx6q_pcie_enable_ref_clk(struct imx_pcie
> *imx_pcie, bool enable)
> >  	return 0;
> >  }
> >
> > -static int imx8mm_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool
> > enable)
> > +static int imx8mm_pcie_clkreq_override(struct imx_pcie *imx_pcie,
> > +bool enable)
> >  {
> >  	int offset = imx_pcie_grp_offset(imx_pcie);
> >
> > @@ -1872,7 +1872,7 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >  		.mode_off[1] = IOMUXC_GPR12,
> >  		.mode_mask[1] = IMX8MQ_GPR12_PCIE2_CTRL_DEVICE_TYPE,
> >  		.init_phy = imx8mq_pcie_init_phy,
> > -		.enable_ref_clk = imx8mm_pcie_enable_ref_clk,
> > +		.enable_ref_clk = imx8mm_pcie_clkreq_override,
> 
> I remember bjorn like callback impliment function name should include
> callback name, here is "enable_ref_clk" to grep easily later.
Is it possible to add one wrapper? Thus, we can align the func-names.
-static int imx8mm_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable)
+static int imx8mm_pcie_clkreq_override(struct imx_pcie *imx_pcie, bool enable)
 {
        int offset = imx_pcie_grp_offset(imx_pcie);

@@ -698,6 +698,11 @@ static int imx8mm_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable)
        return 0;
 }

+static int imx8mm_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable)
+{
+       return imx8mm_pcie_clkreq_override(imx_pcie, enable);
+}
+

Best Regards
Richard Zhu
> 
> Frank
> 
> >  	},
> >  	[IMX8MM] = {
> >  		.variant = IMX8MM,
> > @@ -1882,7 +1882,7 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >  		.gpr = "fsl,imx8mm-iomuxc-gpr",
> >  		.mode_off[0] = IOMUXC_GPR12,
> >  		.mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE,
> > -		.enable_ref_clk = imx8mm_pcie_enable_ref_clk,
> > +		.enable_ref_clk = imx8mm_pcie_clkreq_override,
> >  	},
> >  	[IMX8MP] = {
> >  		.variant = IMX8MP,
> > @@ -1892,7 +1892,7 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >  		.gpr = "fsl,imx8mp-iomuxc-gpr",
> >  		.mode_off[0] = IOMUXC_GPR12,
> >  		.mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE,
> > -		.enable_ref_clk = imx8mm_pcie_enable_ref_clk,
> > +		.enable_ref_clk = imx8mm_pcie_clkreq_override,
> >  	},
> >  	[IMX8Q] = {
> >  		.variant = IMX8Q,
> > @@ -1926,7 +1926,7 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >  		.mode_mask[1] = IMX8MQ_GPR12_PCIE2_CTRL_DEVICE_TYPE,
> >  		.epc_features = &imx8q_pcie_epc_features,
> >  		.init_phy = imx8mq_pcie_init_phy,
> > -		.enable_ref_clk = imx8mm_pcie_enable_ref_clk,
> > +		.enable_ref_clk = imx8mm_pcie_clkreq_override,
> >  	},
> >  	[IMX8MM_EP] = {
> >  		.variant = IMX8MM_EP,
> > @@ -1937,7 +1937,7 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >  		.mode_off[0] = IOMUXC_GPR12,
> >  		.mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE,
> >  		.epc_features = &imx8m_pcie_epc_features,
> > -		.enable_ref_clk = imx8mm_pcie_enable_ref_clk,
> > +		.enable_ref_clk = imx8mm_pcie_clkreq_override,
> >  	},
> >  	[IMX8MP_EP] = {
> >  		.variant = IMX8MP_EP,
> > @@ -1948,7 +1948,7 @@ static const struct imx_pcie_drvdata drvdata[] = {
> >  		.mode_off[0] = IOMUXC_GPR12,
> >  		.mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE,
> >  		.epc_features = &imx8m_pcie_epc_features,
> > -		.enable_ref_clk = imx8mm_pcie_enable_ref_clk,
> > +		.enable_ref_clk = imx8mm_pcie_clkreq_override,
> >  	},
> >  	[IMX8Q_EP] = {
> >  		.variant = IMX8Q_EP,
> > --
> > 2.37.1
> >