[PATCH RFC 5/7] i2c: davinci: calculate bus freq from Hz instead of kHz

Marcus Folkesson marcus.folkesson at gmail.com
Mon Sep 22 07:50:11 PDT 2025


Hi Bartosz,

On Mon, Sep 22, 2025 at 07:42:43AM -0700, Bartosz Golaszewski wrote:
> On Mon, 22 Sep 2025 08:21:00 +0200, Marcus Folkesson
> <marcus.folkesson at gmail.com> said:
> > The bus frequency is unnecessarily converted between Hz and kHz in
> > several places.
> > This is probably an old legacy from the old times (pre-devicetrees)
> > when the davinci_i2c_platform_data took the bus_freq in kHz.
> >
> > Stick to Hz.
> >
> 
> This looks good but would you mind also changing the name of the field to
> bus_freq_hz in order to leave zero change of misinterpreting it in the future?

Thanks for your review!
Sounds fair, I will change the name to bus_freq_hz in v2.

> 
> Bartosz

Best regards,
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250922/e05c1f9d/attachment-0001.sig>


More information about the linux-arm-kernel mailing list