[EXT] Re: [PATCH v2 0/5] media: imx91: Add ISI support

[G.N. Zhou]

Hi Laurent,

Many thanks for you reviews.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Sent: Monday, September 22, 2025 6:31 AM
> To: Frank Li <frank.li at nxp.com>
> Cc: G.N. Zhou <guoniu.zhou at nxp.com>; Mauro Carvalho Chehab
> <mchehab at kernel.org>; Rob Herring <robh at kernel.org>; Krzysztof Kozlowski
> <krzk+dt at kernel.org>; Conor Dooley <conor+dt at kernel.org>; Shawn Guo
> <shawnguo at kernel.org>; Sascha Hauer <s.hauer at pengutronix.de>;
> Pengutronix Kernel Team <kernel at pengutronix.de>; Fabio Estevam
> <festevam at gmail.com>; linux-media at vger.kernel.org;
> devicetree at vger.kernel.org; imx at lists.linux.dev; linux-arm-
> kernel at lists.infradead.org; linux-kernel at vger.kernel.org; Alice Yuan
> <alice.yuan at nxp.com>; Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Subject: [EXT] Re: [PATCH v2 0/5] media: imx91: Add ISI support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> On Sun, Sep 21, 2025 at 07:07:06PM +0300, Laurent Pinchart wrote:
> > On Fri, Sep 19, 2025 at 12:11:38PM -0400, Frank Li wrote:
> > > On Fri, Sep 19, 2025 at 02:40:01AM +0000, G.N. Zhou wrote:
> > > > Hi,
> > > >
> > > > Could you help to please review the patches which I have submitted
> > > > some time back to linux media community and move forward driver
> > > > part if possible.
> > > >
> > > > Your feedback will be very appreciated. Thanks.
> > > >
> > > > Best Regards
> > > > G.N Zhou
> > >
> > > Laurent Pinchart:
> > >
> > >     Could you please consider pickup these patches? Consider these
> > > related simple changes, is my Reviewed-by enough?
> >
> > I've completed a set of other reviews and will get to this patch
> > series in the upcoming week.
> 
> There's just an open question on 2/5. It's about the commit message, so it
> shouldn't be a big deal. Once I get a reply to that, I can apply the series with the
> small proposed changes, there's no need to submit a v3, unless you prefer
> doing so.

I'm very happy to follow your advices and apply on your side as you said. Thank you very much.

> 
> > > > >
> > > > > Add ISI support for i.MX91 chip.
> > > > >
> > > > > The bellow patch refine code, no functions changed.
> > > > >    media: nxp: imx8-isi: Simplify code by using helper macro
> > > > >    media: nxp: imx8-isi: Reorder the platform data
> > > > >
> > > > > The bindings and driver patch for i.MX91 ISI.
> > > > >    media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string
> > > > >    media: nxp: imx8-isi: Add ISI support for i.MX91
> > > > >
> > > > > Add parallel camera input for i.MX93 ISI.
> > > > >    media: nxp: imx8-isi: Add parallel camera input support
> > > > >
> > > > > Signed-off-by: Guoniu Zhou <guoniu.zhou at nxp.com>
> > > > > ---
> > > > > Changes in v2:
> > > > > - Update commit log in patch 5 to better describe why introduce it.
> > > > > - Include two header files in patch 2 since kernel test robot report build
> > > > >   issue when arch is riscv and compiler is clang-22.
> > > > >   #include <linux/bitfield.h>
> > > > >   #include <linux/bits.h>
> > > > > - Link to v1:
> > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%
> > > > > 2Flore.kernel.org%2Fall%2F20250827-isi_imx93-v1-0-
> &data=05%7C02%
> > > > >
> 7Cguoniu.zhou%40nxp.com%7C160464d861a24abf246e08ddf95e93bd%7C68
> 6
> > > > >
> ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638940906787985916%7C
> Unk
> > > > >
> nown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCI
> sI
> > > > >
> lAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sda
> > > > >
> ta=MJUx0UV12LxPISHvimNpvs6Sfc8qxXr4Yrrix2N8%2BF8%3D&reserved=0
> > > > > 83e6b4b50c4d at nxp.com
> > > > >
> > > > > ---
> > > > > Alice Yuan (2):
> > > > >       media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string
> > > > >       media: nxp: imx8-isi: Add parallel camera input support
> > > > >
> > > > > Guoniu Zhou (3):
> > > > >       media: nxp: imx8-isi: Simplify code by using helper macro
> > > > >       media: nxp: imx8-isi: Reorder the platform data
> > > > >       media: nxp: imx8-isi: Add ISI support for i.MX91
> > > > >
> > > > >  .../devicetree/bindings/media/nxp,imx8-isi.yaml    | 13 +++++-
> > > > >  .../media/platform/nxp/imx8-isi/imx8-isi-core.c    | 50
> ++++++++++++++--------
> > > > >  .../media/platform/nxp/imx8-isi/imx8-isi-core.h    |  1 +
> > > > >  .../media/platform/nxp/imx8-isi/imx8-isi-gasket.c  | 18
> > > > > ++++++--
> > > > >  4 files changed, 59 insertions(+), 23 deletions(-)
> > > > > ---
> > > > > base-commit: 603957ae903e81fb80d3788297c0f58a68802dfc
> > > > > change-id: 20250826-isi_imx93-4a59288b33e4
> 
> --
> Regards,
> 
> Laurent Pinchart