[PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe()

[Parvathi Pudi]

Hi,

> On Thu, 18 Sep 2025 12:48:26 +0300 Dan Carpenter wrote:
>> This error handling triggers a Smatch warning:
>> 
>>     drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe()
>>     warn: 'prueth->pru1' is an error pointer or valid
>> 
>> The warning is harmless because the pru_rproc_put() function has an
>> IS_ERR_OR_NULL() check built in.  However, there is a small bug if
>> syscon_regmap_lookup_by_phandle() fails.  In that case we should call
>> of_node_put() on eth0_node and eth1_node.
>> 
>> It's a little bit easier to re-write this code to only free things which
>> we know have been allocated successfully.
> 
> icssm maintainers - please review

Yes you are correct. This got missed somehow sorry about that.

Now the error return is gracefully exiting by freeing the resources.

Reviewed-by: Parvathi Pudi <parvathi at couthit.com>


Thanks and Regards,
Parvathi.